> -----Original Message----- > From: Jason Gunthorpe <jgg@xxxxxxxx> > Sent: Monday, November 23, 2020 10:02 AM > To: Xiong, Jianxin <jianxin.xiong@xxxxxxxxx> > Cc: linux-rdma@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky > <leon@xxxxxxxxxx>; Sumit Semwal <sumit.semwal@xxxxxxxxxx>; Christian Koenig <christian.koenig@xxxxxxx>; Vetter, Daniel > <daniel.vetter@xxxxxxxxx> > Subject: Re: [PATCH rdma-core 2/5] mlx5: Support dma-buf based memory region > > On Mon, Nov 23, 2020 at 09:53:01AM -0800, Jianxin Xiong wrote: > > > +struct ibv_mr *mlx5_reg_dmabuf_mr(struct ibv_pd *pd, uint64_t offset, size_t length, > > + uint64_t iova, int fd, int acc) { > > + struct mlx5_mr *mr; > > + int ret; > > + enum ibv_access_flags access = (enum ibv_access_flags)acc; > > Why? It's copied from mlx5_reg_mr(). Didn't pay attention to this but looks unnecessary now. > > Jason _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel