On Thu, 12 Nov 2020, Sam Ravnborg wrote: > On Thu, Nov 12, 2020 at 07:00:10PM +0000, Lee Jones wrote: > > The comment about them (also removed) says: > > > > /* fb_rsrc and aper_rsrc aren't really used currently, but still exist > > * in case we decide we need information on the BAR for BSD in the > > * future. > > */ > > > > Well that was written 12 years ago in 2008. We are now in the future > > and they are still superfluous. We can always add them again at a > > later date if they are ever required. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/savage/savage_bci.c: In function ‘savage_driver_firstopen’: > > drivers/gpu/drm/savage/savage_bci.c:580:24: warning: variable ‘aper_rsrc’ set but not used [-Wunused-but-set-variable] > > drivers/gpu/drm/savage/savage_bci.c:580:15: warning: variable ‘fb_rsrc’ set but not used [-Wunused-but-set-variable] > > > > Cc: David Airlie <airlied@xxxxxxxx> > > Cc: Daniel Vetter <daniel@xxxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> > > --- > > Thanks, applied to drm-misc-next. Thanks for your prompt response Sam. Much appreciated. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
