On Tue, Nov 10, 2020 at 4:41 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Tue, 10 Nov 2020, Sam Ravnborg wrote: > > > Hi Lee, > > > > > > the *d.h headers are supposed to just be hardware definitions. I'd > > > > prefer to keep driver stuff out of them. > > > > > > That's fine (I did wonder if that were the case). > > > > > > I need an answer from you and Sam whether I can create new headers. > > > > > > For me, it is the right thing to do. > > > > Please follow the advice of Alex for the radeon driver. > > Great. Thanks for resolving this Sam. > > Will fix all occurrences. I'm not really following these patch sets you are sending out. They all seem completely independent. I was expecting updated versions with feedback integrated, but they seem to be just different fixes. Are you planning to send out updated versions based on feedback from these series? Also, some of the patches have subtle errors in them (e.g., wrong descriptions of variables, wrong copyright headers on new files, etc.), do you mind if I fix them up locally when applying or would you rather I point out the changes and you can integrate them and resend? Thanks, Alex > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
