Hi, Thomas, OK, I will describe the patch more precisely in the future. Thanks again!!! Have a good day. Kuo-Hsiang Chou -----Original Message----- From: Thomas Zimmermann [mailto:tzimmermann@xxxxxxx] Sent: Monday, November 09, 2020 6:26 PM To: Kuo-Hsiang Chou <kuohsiang_chou@xxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Cc: airlied@xxxxxxxxxx; airlied@xxxxxxxx; daniel@xxxxxxxx; Jenmin Yuan <jenmin_yuan@xxxxxxxxxxxxxx>; Arc Sung <arc_sung@xxxxxxxxxxxxxx>; Tommy Huang <tommy_huang@xxxxxxxxxxxxxx> Subject: Re: [PATCH] drm/ast: Create chip AST2600 Hi Am 09.11.20 um 10:38 schrieb KuoHsiang Chou: > [New] Support AST2600 A style issue: better write a nice sentence than these tags. For the patch at hand, I'd preferred something like: "Only add an id for supporting AST2600. No functional changes are required." I assume that there areno further changes required for AST2600. > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou@xxxxxxxxxxxxxx> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> I'll add the patch to drm-misc-next. Thanks! Best regards Thomas > --- > drivers/gpu/drm/ast/ast_drv.h | 1 + > drivers/gpu/drm/ast/ast_main.c | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/ast/ast_drv.h > b/drivers/gpu/drm/ast/ast_drv.h index 467049ca8430..6b9e3b94a712 > 100644 > --- a/drivers/gpu/drm/ast/ast_drv.h > +++ b/drivers/gpu/drm/ast/ast_drv.h > @@ -63,6 +63,7 @@ enum ast_chip { > AST2300, > AST2400, > AST2500, > + AST2600, > }; > > enum ast_tx_chip { > diff --git a/drivers/gpu/drm/ast/ast_main.c > b/drivers/gpu/drm/ast/ast_main.c index 77066bca8793..4ec6884f6c65 > 100644 > --- a/drivers/gpu/drm/ast/ast_main.c > +++ b/drivers/gpu/drm/ast/ast_main.c > @@ -143,7 +143,10 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post) > ast_detect_config_mode(dev, &scu_rev); > > /* Identify chipset */ > - if (dev->pdev->revision >= 0x40) { > + if (dev->pdev->revision >= 0x50) { > + ast->chip = AST2600; > + drm_info(dev, "AST 2600 detected\n"); > + } else if (dev->pdev->revision >= 0x40) { > ast->chip = AST2500; > drm_info(dev, "AST 2500 detected\n"); > } else if (dev->pdev->revision >= 0x30) { > -- > 2.18.4 > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
