On Fri, Nov 06, 2020 at 04:20:34PM +0000, Xiong, Jianxin wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxx> > > Sent: Thursday, November 05, 2020 4:13 PM > > To: Xiong, Jianxin <jianxin.xiong@xxxxxxxxx> > > Cc: linux-rdma@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Doug Ledford <dledford@xxxxxxxxxx>; Leon Romanovsky > > <leon@xxxxxxxxxx>; Sumit Semwal <sumit.semwal@xxxxxxxxxx>; Christian Koenig <christian.koenig@xxxxxxx>; Vetter, Daniel > > <daniel.vetter@xxxxxxxxx> > > Subject: Re: [PATCH v8 3/5] RDMA/uverbs: Add uverbs command for dma-buf based MR registration > > > > On Thu, Nov 05, 2020 at 02:48:07PM -0800, Jianxin Xiong wrote: > > > > > + ret = ib_check_mr_access(access_flags); > > > + if (ret) > > > + return ret; > > > > This should also reject unsupportable flags like ACCESS_ON_DEMAND and HUGETLB > > Will do. Just change IB_ACCESS_SUPPORTED to the list of allowed flags in this context > > > + mr->device = pd->device; > > > + mr->pd = pd; > > > + mr->type = IB_MR_TYPE_USER; > > > + mr->uobject = uobj; > > > + atomic_inc(&pd->usecnt); > > > > Fix intending when copying code please > > It could be due to a mix of tab and space. They look aligned in the source file. Will fix. The interior spaces before the = should not be there, we don't align ='s Jason _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
