Hi Tomi and Sebastian,
Thank you for the patch.
On Thu, Nov 05, 2020 at 02:02:42PM +0200, Tomi Valkeinen wrote:
> From: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
>
> The write buffers are not modified, so they can be constant.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 24 ++++++++++++------------
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 10 +++++-----
> 2 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 86b9d435fb94..22d74d762a10 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -2601,11 +2601,11 @@ static inline void dsi_vc_write_long_payload(struct dsi_data *dsi, int channel,
> }
>
> static int dsi_vc_send_long(struct dsi_data *dsi, int channel, u8 data_type,
> - u8 *data, u16 len, u8 ecc)
> + const u8 *data, u16 len, u8 ecc)
> {
> /*u32 val; */
> int i;
> - u8 *p;
> + const u8 *p;
> int r = 0;
> u8 b1, b2, b3, b4;
>
> @@ -2698,7 +2698,7 @@ static int dsi_vc_send_null(struct dsi_data *dsi, int channel)
> }
>
> static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel,
> - u8 *data, int len,
> + const u8 *data, int len,
> enum dss_dsi_content_type type)
> {
> int r;
> @@ -2729,7 +2729,7 @@ static int dsi_vc_write_nosync_common(struct dsi_data *dsi, int channel,
> }
>
> static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len)
> + const u8 *data, int len)
> {
> struct dsi_data *dsi = to_dsi_data(dssdev);
>
> @@ -2738,7 +2738,7 @@ static int dsi_vc_dcs_write_nosync(struct omap_dss_device *dssdev, int channel,
> }
>
> static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len)
> + const u8 *data, int len)
> {
> struct dsi_data *dsi = to_dsi_data(dssdev);
>
> @@ -2747,7 +2747,7 @@ static int dsi_vc_generic_write_nosync(struct omap_dss_device *dssdev, int chann
> }
>
> static int dsi_vc_write_common(struct omap_dss_device *dssdev,
> - int channel, u8 *data, int len,
> + int channel, const u8 *data, int len,
> enum dss_dsi_content_type type)
> {
> struct dsi_data *dsi = to_dsi_data(dssdev);
> @@ -2776,15 +2776,15 @@ static int dsi_vc_write_common(struct omap_dss_device *dssdev,
> return r;
> }
>
> -static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel, u8 *data,
> - int len)
> +static int dsi_vc_dcs_write(struct omap_dss_device *dssdev, int channel,
> + const u8 *data, int len)
> {
> return dsi_vc_write_common(dssdev, channel, data, len,
> DSS_DSI_CONTENT_DCS);
> }
>
> -static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel, u8 *data,
> - int len)
> +static int dsi_vc_generic_write(struct omap_dss_device *dssdev, int channel,
> + const u8 *data, int len)
> {
> return dsi_vc_write_common(dssdev, channel, data, len,
> DSS_DSI_CONTENT_GENERIC);
> @@ -2810,7 +2810,7 @@ static int dsi_vc_dcs_send_read_request(struct dsi_data *dsi, int channel,
> }
>
> static int dsi_vc_generic_send_read_request(struct dsi_data *dsi, int channel,
> - u8 *reqdata, int reqlen)
> + const u8 *reqdata, int reqlen)
> {
> u16 data;
> u8 data_type;
> @@ -2983,7 +2983,7 @@ static int dsi_vc_dcs_read(struct omap_dss_device *dssdev, int channel, u8 dcs_c
> }
>
> static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int channel,
> - u8 *reqdata, int reqlen, u8 *buf, int buflen)
> + const u8 *reqdata, int reqlen, u8 *buf, int buflen)
> {
> struct dsi_data *dsi = to_dsi_data(dssdev);
> int r;
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index c4bc1f919ab4..8e96ab2f20b6 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -309,18 +309,18 @@ struct omapdss_dsi_ops {
>
> /* data transfer */
> int (*dcs_write)(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len);
> + const u8 *data, int len);
> int (*dcs_write_nosync)(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len);
> + const u8 *data, int len);
> int (*dcs_read)(struct omap_dss_device *dssdev, int channel, u8 dcs_cmd,
> u8 *data, int len);
>
> int (*gen_write)(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len);
> + const u8 *data, int len);
> int (*gen_write_nosync)(struct omap_dss_device *dssdev, int channel,
> - u8 *data, int len);
> + const u8 *data, int len);
> int (*gen_read)(struct omap_dss_device *dssdev, int channel,
> - u8 *reqdata, int reqlen,
> + const u8 *reqdata, int reqlen,
> u8 *data, int len);
>
> int (*bta_sync)(struct omap_dss_device *dssdev, int channel);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
