To Sir Yes, I ran scripts/checkpatch.pl and cleared 3 errors about tailing spaces. OK, would you please give me the mail-address of Daniel? And <eich@xxxxxxx> will be removed from CC. Because I ran get_maintainers.pl and got the result of " The current directory does not appear to be a linux kernel source tree. " So, I got the information from MAINTAINERS by keyword of "/drm/ast", likes as: DRM DRIVER FOR AST SERVER GRAPHICS CHIPS M: Dave Airlie <airlied@xxxxxxxxxx> R: Thomas Zimmermann <tzimmermann@xxxxxxx> L: dri-devel@xxxxxxxxxxxxxxxxxxxxx S: Supported T: git git://anongit.freedesktop.org/drm/drm-misc F: drivers/gpu/drm/ast/ Thanks and Have a good day, Kuo-Hsiang Chou -----Original Message----- From: Thomas Zimmermann [mailto:tzimmermann@xxxxxxx] Sent: Thursday, November 05, 2020 8:09 PM To: Kuo-Hsiang Chou <kuohsiang_chou@xxxxxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx Cc: eich@xxxxxxxx; Tommy Huang <tommy_huang@xxxxxxxxxxxxxx>; Jenmin Yuan <jenmin_yuan@xxxxxxxxxxxxxx>; airlied@xxxxxxxxxx; Arc Sung <arc_sung@xxxxxxxxxxxxxx> Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue Hi, please follow the advise we're giving you. Had you run scripts/checkpatch.pl on the patch file it would have told you <<< ERROR: patch seems to be corrupt (line wrapped?) #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294: ERROR: DOS line endings #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo +|^M$ ERROR: DOS line endings #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300: +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo +|^M$ total: 3 errors, 0 warnings, 19 lines checked >>> As said before, the mail eich@xxxxxxx is still not relevant any longer. But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl? Best regards Thomas Am 05.11.20 um 10:47 schrieb KuoHsiang Chou: > [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz > from Negtive to Positive > > Signed-off-by: KuoHsiang Chou <kuohsiang_chou@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/ast/ast_tables.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_tables.h > b/drivers/gpu/drm/ast/ast_tables.h > index 8414e543f260..51efc5b4a55c 100644 > --- a/drivers/gpu/drm/ast/ast_tables.h > +++ b/drivers/gpu/drm/ast/ast_tables.h > @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable > res_1600x900[] = { > > static const struct ast_vbios_enhtable res_1920x1080[] = { > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +| > AST2500PreCatchCRT), 60, 1, 0x38 }, > {2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5, /* 60Hz */ > - (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo | > + (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo > +| > AST2500PreCatchCRT), 0xFF, 1, 0x38 }, }; > > -- > 2.18.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
