04.11.2020 12:23, Jon Hunter пишет:
> Deferred probe is an expected return value for tegra_output_probe().
> Given that the driver deals with it properly, there's no need to output
> a warning that may potentially confuse users.
>
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> ---
>
> Changes since V1:
> - This time, I actually validated it!
>
> drivers/gpu/drm/tegra/sor.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
> index e88a17c2937f..898a80ca37fa 100644
> --- a/drivers/gpu/drm/tegra/sor.c
> +++ b/drivers/gpu/drm/tegra/sor.c
> @@ -3764,10 +3764,9 @@ static int tegra_sor_probe(struct platform_device *pdev)
> return err;
>
> err = tegra_output_probe(&sor->output);
> - if (err < 0) {
> - dev_err(&pdev->dev, "failed to probe output: %d\n", err);
> - return err;
> - }
> + if (err < 0)
> + return dev_err_probe(&pdev->dev, err,
> + "failed to probe output: %d\n", err);
Hello Jon,
There is no need to duplicate the error code in the message [1]. Perhaps
worth making a v3? :)
[1]
https://elixir.bootlin.com/linux/v5.10-rc2/source/drivers/base/core.c#L4240
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
