On Mon, Nov 02, 2020 at 06:06:04PM +0200, Ville Syrjälä wrote:
> On Mon, Nov 02, 2020 at 02:38:34PM +0100, Maxime Ripard wrote:
> > Now that atomic_check takes the global atomic state as a parameter, we
> > don't need to go through the pointer in the CRTC state.
> >
> > This was done using the following coccinelle script:
> >
> > @ crtc_atomic_func @
> > identifier helpers;
> > identifier func;
> > @@
> >
> > static struct drm_crtc_helper_funcs helpers = {
> > ...,
> > .atomic_check = func,
> > ...,
> > };
> >
> > @@
> > identifier crtc_atomic_func.func;
> > identifier crtc, state;
> > @@
> >
> > func(struct drm_crtc *crtc, struct drm_atomic_state *state) {
> > ...
> > - struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
> > ... when != crtc_state
> > - crtc_state->state
> > + state
> > ...
> > }
> >
> > @@
> > struct drm_crtc_state *crtc_state;
> > identifier crtc_atomic_func.func;
> > identifier crtc, state;
> > @@
> >
> > func(struct drm_crtc *crtc, struct drm_atomic_state *state) {
> > ...
> > - crtc_state->state
> > + state
> > ...
> > }
> >
> > Suggested-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
>
> lgtm
> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Applied, thanks!
Maxime
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
