Re: [PATCH] drm/vc4: Rework the structure convertion functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 28, 2020 at 01:49:29PM +0000, Dave Stevenson wrote:
> s/convertion/conversion in subject line
> 
> On Wed, 28 Oct 2020 at 12:37, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
> >
> > Most of the helpers to retrieve vc4 structures from the DRM base structures
> > rely on the fact that the first member of the vc4 structure is the DRM one
> > and just cast the pointers between them.
> >
> > However, this is pretty fragile especially since there's no check to make
> > sure that the DRM structure is indeed at the offset 0 in the structure, so
> > let's use container_of to make it more robust.
> >
> > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
> 
> Otherwise
> Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

Fixed the typo and applied, thanks!
Maxime

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux