Hi, On Wed, Oct 28, 2020 at 6:11 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > These register reads and writes are sometimes directly next to each > other in the register address space. Let's use regmap bulk read/write > APIs to get the data with one transfer instead of multiple i2c > transfers. This helps cut down on the number of transfers in the case of > something like reading an EDID where we read in blocks of 16 bytes at a > time and the last for loop here is sending an i2c transfer for each of > those 16 bytes, one at a time. Ouch! > > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Jonas Karlman <jonas@xxxxxxxxx> > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx> +Sam Ravnborg has helped land a few changes to this bridge drive in the past, so maybe good to CC him if you have future spins? > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 50 ++++++++++++--------------- > 1 file changed, 22 insertions(+), 28 deletions(-) Since we already did some early reviews off-list, it's not a surprise that I have no comments. ;-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
