On Sun, Oct 25, 2020 at 4:52 PM Guido Günther <agx@xxxxxxxxxxx> wrote:
>
> Hi Daniel,
> On Sat, Oct 24, 2020 at 04:59:16PM +0000, Daniel Abrecht wrote:
> > This will make sure applications which use the IN_FORMATS blob
> > to figure out which modifiers they can use will pick up the
> > linear modifier which is needed by mxsfb. Such applications
> > will not work otherwise if an incompatible implicit modifier
> > ends up being selected.
>
> Since this got broken by the switch away for the simple display
> pipeline helper (ae1ed0093281939b80664a687689f12436c0e874) could
> you add a fixes tag?
mxsfb is also missing setting the allow_fb_modifiers flag, without
which all this modifier stuff won't work great. Please add that too. I
guess some igt testing for this might be useful too, but not sure we
can do that with sufficient generality. It should fall over though
since if you try to create an fb with modifiers you'll fail, so no
idea what userspace you have here.
-Daniel
> Cheers,
> -- Guido
>
> >
> > Signed-off-by: Daniel Abrecht <public@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> > b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> > index 956f631997f2..fc4b1626261b 100644
> > --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> > +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
> > @@ -484,6 +484,13 @@ static void mxsfb_plane_overlay_atomic_update(struct
> > drm_plane *plane,
> > writel(ctrl, mxsfb->base + LCDC_AS_CTRL);
> > }
> >
> > +static bool mxsfb_format_mod_supported(struct drm_plane *plane,
> > + uint32_t format,
> > + uint64_t modifier)
> > +{
> > + return modifier == DRM_FORMAT_MOD_LINEAR;
> > +}
> > +
> > static const struct drm_plane_helper_funcs mxsfb_plane_primary_helper_funcs
> > = {
> > .atomic_check = mxsfb_plane_atomic_check,
> > .atomic_update = mxsfb_plane_primary_atomic_update,
> > @@ -495,6 +502,7 @@ static const struct drm_plane_helper_funcs
> > mxsfb_plane_overlay_helper_funcs = {
> > };
> >
> > static const struct drm_plane_funcs mxsfb_plane_funcs = {
> > + .format_mod_supported = mxsfb_format_mod_supported,
> > .update_plane = drm_atomic_helper_update_plane,
> > .disable_plane = drm_atomic_helper_disable_plane,
> > .destroy = drm_plane_cleanup,
> > --
> > 2.20.1
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
