On Tuesday, October 20, 2020 10:35 AM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote: > There's a confusion between the preferred_depth uapi and the generic > fbdev helpers. Former wants depth, latter wants bpp, and for XRGB8888 > they don't match. Which hit me with vkms, which wants that. > > All other drivers setting this and using the generic fbdev helpers use > 16, where both numbers match, for RGB565. Not quite: grepping reveals a majority of 24 (as shown in drmdb). A few drivers set 16 (udl, cirrus), and hisilicon sets 32. > Since fixing this is a bit involved (I think for atomic drivers we > should just compute this all internally from the format list of the > first primary plane) paper over the issue in vkms by using defaults > everywhere. Then userspace will pick XRGB8888, and fbdev helpers will > do the same, and we have what we want. > > Reported-by: Simon Ser contact@xxxxxxxxxxx > Cc: Simon Ser contact@xxxxxxxxxxx > Signed-off-by: Daniel Vetter daniel.vetter@xxxxxxxxx > Cc: Rodrigo Siqueira rodrigosiqueiramelo@xxxxxxxxx > Cc: Melissa Wen melissa.srw@xxxxxxxxx > Cc: Haneen Mohammed hamohammed.sa@xxxxxxxxx > Cc: Daniel Vetter daniel@xxxxxxxx With the commit message clarified: Reviewed-by: Simon Ser <contact@xxxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
