On Fri, Oct 16, 2020 at 07:10:56AM -0300, Melissa Wen wrote: > Hi, > > Thanks for this improvement. > > I could see that it increased the IGT test coverage, including now the > fbdev test cases. > > On 10/10, Daniel Vetter wrote: > > Hooray for generic fbdev support, making this a oneliner. We just > > needed to fix preferred_depth fixed and the vmap support added first. > > I consider that including in the msg that, with this patch, both fbdev > test cases [info and mmap] are passing would be interesting for future > debugs. Done and patch applied, thanks for taking a look. I'll also follow up with a quick patch to paper over the fbdev vs preferred_depth issue, until we have a proper solution for all that. -Daniel > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> > > Cc: Melissa Wen <melissa.srw@xxxxxxxxx> > > Cc: Haneen Mohammed <hamohammed.sa@xxxxxxxxx> > > Cc: Daniel Vetter <daniel@xxxxxxxx> > > --- > > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > > index 6221e5040264..cc09e2df5cb1 100644 > > --- a/drivers/gpu/drm/vkms/vkms_drv.c > > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > > @@ -169,6 +169,8 @@ static int __init vkms_init(void) > > if (ret) > > goto out_devres; > > > > + drm_fbdev_generic_setup(&vkms_device->drm, 0); > > + > > return 0; > > > > out_devres: > > -- > > 2.28.0 > > > > Looks good to me, > > Reviewed-by: Melissa Wen <melissa.srw@xxxxxxxxx> -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
