On Fri, Oct 16, 2020 at 6:03 PM KuoHsiang Chou <kuohsiang_chou@xxxxxxxxxxxxxx> wrote: > > The patch is upstreamed > 1. For RHEL7.x, because its native kernel is suggested to update > from 3.10 to 4.9 on 2 ODM's platform. > 2. For AST2600. > 3. For ASTDP. > 4. v1.11 Hi, I've cc'ed Thomas who is maintaining this upstream, but this patch in it's current form isn't acceptable, Maybe Thomas can provide more detailed info, but the basic rules are One patch should do one thing. Patches should be bisectable so any issues can be tracked down easier. Fixes should be separated from new code. New features and chip support should be separate. https://www.kernel.org/doc/html/v5.9/process/submitting-patches.html Please maybe work with Thomas on having a better upstream development process for ast chipsets. Thanks, Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel