On 10/15, Daniel Vetter wrote: > On Mon, Oct 12, 2020 at 09:59:22AM -0300, Melissa Wen wrote: > > On 10/10, Daniel Vetter wrote: > > > The only thing we support is xrgb8888. > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > > > Cc: Rodrigo Siqueira <rodrigosiqueiramelo@xxxxxxxxx> > > > Cc: Melissa Wen <melissa.srw@xxxxxxxxx> > > > Cc: Haneen Mohammed <hamohammed.sa@xxxxxxxxx> > > > Cc: Daniel Vetter <daniel@xxxxxxxx> > > > --- > > > drivers/gpu/drm/vkms/vkms_drv.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > > > index 726801ab44d4..eb4007443706 100644 > > > --- a/drivers/gpu/drm/vkms/vkms_drv.c > > > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > > > @@ -124,7 +124,7 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev) > > > dev->mode_config.max_height = YRES_MAX; > > > dev->mode_config.cursor_width = 512; > > > dev->mode_config.cursor_height = 512; > > > - dev->mode_config.preferred_depth = 24; > > > + dev->mode_config.preferred_depth = 32; > > nice catch! > > > > > dev->mode_config.helper_private = &vkms_mode_config_helpers; > > > > > > return vkms_output_init(vkmsdev, 0); > > > -- > > > 2.28.0 > > > > > Thanks, > > > > Reviewed-by: Melissa Wen <melissa.srw@xxxxxxxxx> > > I merged the first 2 patches of this series, but noticed that you didn't > reply with a r-b tag on the 3rd patch. Is that intentional or just > oversight? Hi Daniel, Initially, it was intentional because I was following the feedback and still wanted to check it out better, then I forgot to come back to comment. My fault, but it's done now. Thanks for the touch, Melissa > > Thanks, Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
