Re: [PATCH v3 09/20] gpu: host1x: DMA fences and userspace fence creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikko,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra-drm/drm/tegra/for-next]
[also build test WARNING on tegra/for-next linus/master v5.9-rc8 next-20201007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201008-034403
base:   git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: arm64-randconfig-r004-20201008 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c4f5ec983027f2b19e6854a362e23a79e1630100
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mikko-Perttunen/Host1x-TegraDRM-UAPI/20201008-034403
        git checkout c4f5ec983027f2b19e6854a362e23a79e1630100
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/host1x/fence.c:105:6: warning: no previous prototype for 'host1x_fence_signal' [-Wmissing-prototypes]
     105 | void host1x_fence_signal(struct host1x_syncpt_fence *f)
         |      ^~~~~~~~~~~~~~~~~~~

vim +/host1x_fence_signal +105 drivers/gpu/host1x/fence.c

   104	
 > 105	void host1x_fence_signal(struct host1x_syncpt_fence *f)
   106	{
   107		if (atomic_xchg(&f->signaling, 1))
   108			return;
   109	
   110		/*
   111		 * Cancel pending timeout work - if it races, it will
   112		 * not get 'f->signaling' and return.
   113		 */
   114		cancel_delayed_work_sync(&f->timeout_work);
   115	
   116		host1x_intr_put_ref(f->sp->host, f->sp->id, f->waiter_ref);
   117	
   118		dma_fence_signal(&f->base);
   119		dma_fence_put(&f->base);
   120	}
   121	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux