Hi Sam Am 25.09.20 um 23:55 schrieb Sam Ravnborg: > Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") > introduced the following build error: > > rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here > 304 | .vm_ops = &drm_gem_cma_vm_ops, > | ^~~~~~~~~~~~~~~~~~ > | drm_gem_mmap_obj > > Fixed by adding missing include file. > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Didn't you review exactly this change yesterday? Anyway, you should add Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") and Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> It might happen that I land my patch first, depending on the urgency of the issue. Best regards Thomas > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Sandy Huang <hjc@xxxxxxxxxxxxxx> > Cc: "Heiko Stübner" <heiko@xxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index bb3578469b03..6da15faf0192 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -10,6 +10,7 @@ > > #include <drm/drm.h> > #include <drm/drm_gem.h> > +#include <drm/drm_gem_cma_helper.h> > #include <drm/drm_prime.h> > #include <drm/drm_vma_manager.h> > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel