On Mon, 28 Sep 2020, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > Why are we adding IS_JASPERLAKE at all? EHL/JSL are documented as the > same graphics IP, but are paired with different PCHs in the final SoCs, > which is what causes the minor differences in programming. My > understanding is that the voltage programming differences are ultimately > due to that difference in PCH so we should just use HAS_PCH_MCC (EHL) > and HAS_PCH_JSP (JSL) to distinguish which type of programming is needed > rather than using a platform test. Good point. If the difference is in the PCH, then of course the PCH check should be used instead. Which avoids the problem altogether. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
