Re: [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies if present

["Alex G." <mr.nuke.me@xxxxxxxxx>]

On 9/24/20 3:22 PM, Fabio Estevam wrote:
Hi Fabio,

> On Thu, Sep 24, 2020 at 5:16 PM Alexandru Gagniuc <mr.nuke.me@xxxxxxxxx> wrote:
>
> > +       ret = regulator_enable(sii902x->cvcc12);
> > +       if (ret < 0) {
> > +               dev_err(dev, "Failed to enable cvcc12 supply: %d\n", ret);
> > +               regulator_disable(sii902x->iovcc);
> > +               return PTR_ERR(sii902x->cvcc12);
>
> return ret;

Thank you for catching that. I will fix it in v2.

> >          ret = regmap_write(sii902x->regmap, SII902X_REG_TPI_RQB, 0x0);
> > @@ -1012,11 +1052,11 @@ static int sii902x_probe(struct i2c_client *client,
> >          regmap_read(sii902x->regmap, SII902X_INT_STATUS, &status);
> >          regmap_write(sii902x->regmap, SII902X_INT_STATUS, status);
> >
> > -       if (client->irq > 0) {
> > +       if (sii902x->i2c->irq > 0) {
>
> Unrelated change.
[snip]
>   Unrelated change.
[snip]
> Unrelated change.
[snip]
> Unrelated change.

The i2c initialization is moved into a separate function. Hence 'client' 
is no longer available. Instead, it can be accessed via 'sii902x->i2c'.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel