Re: [PATCH 05/10] drm/ttm: add bo wait that takes a ctx wrapper.

[Christian König <christian.koenig@xxxxxxx>]

Am 23.09.20 um 05:04 schrieb Dave Airlie:
> From: Dave Airlie <airlied@xxxxxxxxxx>
>
> I'm thinking of pushing the wait into the drivers.
>
> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++--
>   drivers/gpu/drm/qxl/qxl_ttm.c        | 2 +-
>   drivers/gpu/drm/radeon/radeon_ttm.c  | 2 +-
>   drivers/gpu/drm/ttm/ttm_bo_util.c    | 4 ++--
>   include/drm/ttm/ttm_bo_api.h         | 5 +++++
>   5 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 8a90b07f17a4..8d51cfca07c8 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1038,7 +1038,7 @@ nouveau_bo_move(struct ttm_buffer_object *bo, bool evict,
>   	struct nouveau_drm_tile *new_tile = NULL;
>   	int ret = 0;
>   
> -	ret = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +	ret = ttm_bo_wait_ctx(bo, ctx);
>   	if (ret)
>   		return ret;
>   
> @@ -1073,7 +1073,7 @@ nouveau_bo_move(struct ttm_buffer_object *bo, bool evict,
>   	}
>   
>   	/* Fallback to software copy. */
> -	ret = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +	ret = ttm_bo_wait_ctx(bo, ctx);
>   	if (ret == 0)
>   		ret = ttm_bo_move_memcpy(bo, ctx, new_reg);
>   
> diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
> index 01fe0c3a3d9a..2c35ca4270c6 100644
> --- a/drivers/gpu/drm/qxl/qxl_ttm.c
> +++ b/drivers/gpu/drm/qxl/qxl_ttm.c
> @@ -160,7 +160,7 @@ static int qxl_bo_move(struct ttm_buffer_object *bo, bool evict,
>   	struct ttm_resource *old_mem = &bo->mem;
>   	int ret;
>   
> -	ret = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +	ret = ttm_bo_wait_ctx(bo, ctx);
>   	if (ret)
>   		return ret;
>   
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 9ff8c81d7784..ea9ffa6198da 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -302,7 +302,7 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, bool evict,
>   	struct ttm_resource *old_mem = &bo->mem;
>   	int r;
>   
> -	r = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +	r = ttm_bo_wait_ctx(bo, ctx);
>   	if (r)
>   		return r;
>   
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c
> index 1968df9743fc..bdee4df1f3f2 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_util.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c
> @@ -59,7 +59,7 @@ int ttm_bo_move_ttm(struct ttm_buffer_object *bo,
>   	int ret;
>   
>   	if (old_mem->mem_type != TTM_PL_SYSTEM) {
> -		ret = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +		ret = ttm_bo_wait_ctx(bo, ctx);
>   
>   		if (unlikely(ret != 0)) {
>   			if (ret != -ERESTARTSYS)
> @@ -231,7 +231,7 @@ int ttm_bo_move_memcpy(struct ttm_buffer_object *bo,
>   	unsigned long add = 0;
>   	int dir;
>   
> -	ret = ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +	ret = ttm_bo_wait_ctx(bo, ctx);
>   	if (ret)
>   		return ret;
>   
> diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
> index 6cbe59bc97ab..b840756dbcca 100644
> --- a/include/drm/ttm/ttm_bo_api.h
> +++ b/include/drm/ttm/ttm_bo_api.h
> @@ -262,6 +262,11 @@ ttm_bo_get_unless_zero(struct ttm_buffer_object *bo)
>    */
>   int ttm_bo_wait(struct ttm_buffer_object *bo, bool interruptible, bool no_wait);
>   
> +static inline int ttm_bo_wait_ctx(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx)
> +{
> +	return ttm_bo_wait(bo, ctx->interruptible, ctx->no_wait_gpu);
> +}
> +
>   /**
>    * ttm_bo_mem_compat - Check if proposed placement is compatible with a bo
>    *

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel