Re: [PATCH] fbcon: Remove the superfluous break

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2020/9/18 1:36, Nick Desaulniers wrote:
On Thu, Sep 17, 2020 at 6:15 AM Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> wrote:

Remove the superfuous break, as there is a 'return' before it.

superfluous (missed "l")

Thanks for correcting!


Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>

Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Thanks for the patch; I audited the rest of the switch statements in
this translation unit; LGTM.

---
  drivers/video/fbdev/core/fbcon.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 0b49b0f44edf..623359aadd1e 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
                                     vc->vc_video_erase_char,
                                     vc->vc_size_row * count);
                         return true;
-                       break;

                 case SCROLL_WRAP_MOVE:
                         if (b - t - count > 3 * vc->vc_rows >> 2) {
@@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
                                     vc->vc_video_erase_char,
                                     vc->vc_size_row * count);
                         return true;
-                       break;

                 case SCROLL_WRAP_MOVE:
                         if (b - t - count > 3 * vc->vc_rows >> 2) {
--
2.17.1



_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux