On Thu, Sep 17, 2020 at 2:40 AM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
Hi,
> + if (!devm_request_mem_region(&vgdev->vdev->dev,
> + vgdev->host_visible_region.addr,
> + vgdev->host_visible_region.len,
> + dev_name(&vgdev->vdev->dev))) {
> + DRM_ERROR("Could not reserve host visible region\n");
> + goto err_vqs;
> + }
> + if (vgdev->has_host_visible) {
> + devm_release_mem_region(&vgdev->vdev->dev,
> + vgdev->host_visible_region.addr,
> + vgdev->host_visible_region.len);
> + }
Hmm. isn't it the point of the managed apis that the release happens
automatically? I think you don't need the devm_release_mem_region
call (it doesn't break things though).
Ack, good catch. Fixed.
take care,
Gerd
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
