Re: [PATCH 3/7] drm/ttm: move unbind into the tt destroy.

[Christian König <christian.koenig@xxxxxxx>]

Am 17.09.20 um 06:30 schrieb Dave Airlie:
> From: Dave Airlie <airlied@xxxxxxxxxx>
>
> This moves unbind into the driver side on destroy paths.
>
> Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c    | 1 +
>   drivers/gpu/drm/nouveau/nouveau_bo.c       | 1 +
>   drivers/gpu/drm/nouveau/nouveau_sgdma.c    | 1 +
>   drivers/gpu/drm/radeon/radeon_ttm.c        | 2 ++
>   drivers/gpu/drm/ttm/ttm_bo.c               | 1 -
>   drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 1 +
>   6 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index dbe3f90a0cf6..2028b9e4c25c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1267,6 +1267,7 @@ static void amdgpu_ttm_backend_destroy(struct ttm_bo_device *bdev,
>   {
>   	struct amdgpu_ttm_tt *gtt = (void *)ttm;
>   
> +	amdgpu_ttm_backend_unbind(bdev, ttm);
>   	ttm_tt_destroy_common(bdev, ttm);
>   	if (gtt->usertask)
>   		put_task_struct(gtt->usertask);
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index b239381498c3..4a020a3da3dd 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1372,6 +1372,7 @@ nouveau_ttm_tt_destroy(struct ttm_bo_device *bdev,
>   #if IS_ENABLED(CONFIG_AGP)
>   	struct nouveau_drm *drm = nouveau_bdev(bdev);
>   	if (drm->agp.bridge) {
> +		ttm_agp_unbind(ttm);
>   		ttm_tt_destroy_common(bdev, ttm);
>   		ttm_agp_destroy(ttm);
>   		return;
> diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> index 0dfaa6fb536e..806d9ec310f5 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c
> @@ -20,6 +20,7 @@ nouveau_sgdma_destroy(struct ttm_bo_device *bdev, struct ttm_tt *ttm)
>   	struct nouveau_sgdma_be *nvbe = (struct nouveau_sgdma_be *)ttm;
>   
>   	if (ttm) {
> +		nouveau_sgdma_unbind(bdev, ttm);
>   		ttm_tt_destroy_common(bdev, ttm);
>   		ttm_dma_tt_fini(&nvbe->ttm);
>   		kfree(nvbe);
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 76e24c6058ff..03e5ae4e3bf6 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -576,6 +576,7 @@ static void radeon_ttm_backend_destroy(struct ttm_bo_device *bdev, struct ttm_tt
>   {
>   	struct radeon_ttm_tt *gtt = (void *)ttm;
>   
> +	radeon_ttm_backend_unbind(bdev, ttm);
>   	ttm_tt_destroy_common(bdev, ttm);
>   
>   	ttm_dma_tt_fini(&gtt->ttm);
> @@ -757,6 +758,7 @@ static void radeon_ttm_tt_destroy(struct ttm_bo_device *bdev,
>   	struct radeon_device *rdev = radeon_get_rdev(bdev);
>   
>   	if (rdev->flags & RADEON_IS_AGP) {
> +		ttm_agp_unbind(ttm);
>   		ttm_tt_destroy_common(bdev, ttm);
>   		ttm_agp_destroy(ttm);
>   		return;
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 649a7d0a0766..2c527cd20dfa 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1620,7 +1620,6 @@ void ttm_bo_tt_destroy(struct ttm_buffer_object *bo)
>   	if (bo->ttm == NULL)
>   		return;
>   
> -	ttm_bo_tt_unbind(bo);
>   	ttm_tt_destroy(bo->bdev, bo->ttm);
>   	bo->ttm = NULL;
>   }
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> index d46426164577..7454f797d37b 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
> @@ -636,6 +636,7 @@ static void vmw_ttm_destroy(struct ttm_bo_device *bdev, struct ttm_tt *ttm)
>   	struct vmw_ttm_tt *vmw_be =
>   		container_of(ttm, struct vmw_ttm_tt, dma_ttm.ttm);
>   
> +	vmw_ttm_unbind(bdev, ttm);
>   	ttm_tt_destroy_common(bdev, ttm);
>   	vmw_ttm_unmap_dma(vmw_be);
>   	if (vmw_be->dev_priv->map_mode == vmw_dma_alloc_coherent)

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel