Re: [PATCH v2 09/23] virtio-gpu api: blob resources

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Tue, Sep 8, 2020 at 11:55 PM Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
  Hi,

> @@ -100,7 +102,7 @@ struct drm_virtgpu_resource_info {
>       __u32 bo_handle;
>       __u32 res_handle;
>       __u32 size;
> -     __u32 stride;
> +     __u32 blob_mem;
>  };

Huh?  This is not in the virtio spec update proposed.

>  struct drm_virtgpu_3d_box {
> @@ -117,6 +119,8 @@ struct drm_virtgpu_3d_transfer_to_host {
>       struct drm_virtgpu_3d_box box;
>       __u32 level;
>       __u32 offset;
> +     __u32 stride;
> +     __u32 layer_stride;
>  };

Same here.

>  struct drm_virtgpu_3d_transfer_from_host {
> @@ -124,6 +128,8 @@ struct drm_virtgpu_3d_transfer_from_host {
>       struct drm_virtgpu_3d_box box;
>       __u32 level;
>       __u32 offset;
> +     __u32 stride;
> +     __u32 layer_stride;
>  }; 

And here.

Separated out the virtio and DRM api changes, as per your recommendation.  The virtio spec changes should match v6 of the proposed spec.  Explanations for these specific DRM changes here are in patch 16 & patch 17 of the v3 implementation. 
 
take care,
  Gerd

PS: cherry-picked patches 1-3 into drm-misc-next.

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux