Hi Am 11.09.20 um 10:09 schrieb Tian Tao: > Handing the return value of drm_universal_plane_init to fix the following > W=1 kernel build warning(s): > vc4_plane.c: In function ‘vc4_plane_init’: > vc4_plane.c:1340:6: warning: variable ‘ret’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> Thanks! > --- > drivers/gpu/drm/vc4/vc4_plane.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c > index 24d7e6d..65c1205 100644 > --- a/drivers/gpu/drm/vc4/vc4_plane.c > +++ b/drivers/gpu/drm/vc4/vc4_plane.c > @@ -1361,6 +1361,8 @@ struct drm_plane *vc4_plane_init(struct drm_device *dev, > &vc4_plane_funcs, > formats, ARRAY_SIZE(formats), > modifiers, type, NULL); > + if (ret) > + return ERR_PTR(ret); > > drm_plane_helper_add(plane, &vc4_plane_helper_funcs); > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
