Hi Neil, Thanks for your review. Is a device tree binding document like this one enough? Entries for kmb-drm are similar to this. https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/gpu/brcm%2Cbcm-v3d.txt How do I submit it once I have it ready? Thanks, Anitha > -----Original Message----- > From: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Sent: Thursday, September 10, 2020 2:33 AM > To: Chrisanthus, Anitha <anitha.chrisanthus@xxxxxxxxx>; dri- > devel@xxxxxxxxxxxxxxxxxxxxx; Paauwe, Bob J <bob.j.paauwe@xxxxxxxxx>; > Dea, Edmund J <edmund.j.dea@xxxxxxxxx> > Cc: Vetter, Daniel <daniel.vetter@xxxxxxxxx> > Subject: Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display > > On 31/08/2020 22:02, Anitha Chrisanthus wrote: > > This is a basic KMS atomic modesetting display driver for KeemBay family > of > > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > > driver at the connector level. > > > > Single CRTC with LCD controller->mipi DSI-> ADV bridge > > > > Only 1080p resolution and single plane is supported at this time. > > > > v2: moved extern to .h, removed license text > > use drm_dev_init, upclassed dev_private, removed HAVE_IRQ.(Sam) > > > > v3: Squashed all 59 commits to one > > > > v4: review changes from Sam Ravnborg > > renamed dev_p to kmb > > moved clocks under kmb_clock, consolidated clk initializations > > use drmm functions > > use DRM_GEM_CMA_DRIVER_OPS_VMAP > > > > v5: corrected spellings > > v6: corrected checkpatch warnings > > v7: review changes Sam Ravnborg and Thomas Zimmerman > > removed kmb_crtc.h kmb_crtc_cleanup (Thomas) > > renamed mode_set, kmb_load, inlined unload (Thomas) > > moved remaining logging to drm_*(Thomas) > > re-orged driver initialization (Thomas) > > moved plane_status to drm_private (Sam) > > removed unnecessary logs and defines and ifdef codes (Sam) > > call helper_check in plane_atomic_check (Sam) > > renamed set to get for bpp and format functions(Sam) > > use drm helper functions for reset, duplicate/destroy state instead > > of kmb functions (Sam) > > removed kmb_priv from kmb_plane and removed kmb_plane_state > (Sam) > > > > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > > Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@xxxxxxxxx> > > Reviewed-by: Bob Paauwe <bob.j.paauwe@xxxxxxxxx> > > --- > > drivers/gpu/drm/kmb/kmb_crtc.c | 224 +++++++++++++ > > drivers/gpu/drm/kmb/kmb_drv.c | 676 > ++++++++++++++++++++++++++++++++++++++++ > > drivers/gpu/drm/kmb/kmb_drv.h | 170 ++++++++++ > > drivers/gpu/drm/kmb/kmb_plane.c | 480 > ++++++++++++++++++++++++++++ > > drivers/gpu/drm/kmb/kmb_plane.h | 110 +++++++ > > 5 files changed, 1660 insertions(+) > > create mode 100644 drivers/gpu/drm/kmb/kmb_crtc.c > > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.c > > create mode 100644 drivers/gpu/drm/kmb/kmb_drv.h > > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.c > > create mode 100644 drivers/gpu/drm/kmb/kmb_plane.h > > > > [...] > > > + > > +static const struct of_device_id kmb_of_match[] = { > > + {.compatible = "intel,kmb_display"}, > > + {}, > > +}; > > As I already commented on v1, a proper YAML bindings files > is mandatory here, to check if the bindings are correct and if > the drivers uses them correctly (port/endpoints, etc..) > > Neil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
