Hi Lucas, On Thu, Sep 10, 2020 at 12:24:44PM +0200, Lucas Stach wrote: > On Do, 2020-09-10 at 13:21 +0300, Laurentiu Palcu wrote: > > On Thu, Sep 10, 2020 at 11:57:10AM +0200, Daniel Vetter wrote: > > > On Thu, Sep 10, 2020 at 11:53 AM Laurentiu Palcu > > > <laurentiu.palcu@xxxxxxxxxxx> wrote: > > > > When compiling for 32bit platforms, the compilation fails with: > > > > > > > > ERROR: modpost: "__aeabi_ldivmod" > > > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! > > > > ERROR: modpost: "__aeabi_uldivmod" > > > > [drivers/gpu/drm/imx/dcss/imx-dcss.ko] undefined! > > > > > > > > This patch adds a dependency on ARM64 since no 32bit SoCs have DCSS, so far. > > > > > > Usual way to fix this correctly is using the right division macros, > > > not limiting the driver to 64bit. But this works for now, would be > > > good to fix this properly for compile-testing and all that. > > > > I didn't see the point in using the macros since this is running only on > > 64bit. Though I will probably revisit it and fix it properly in a > > subsequent patch. > > > > > > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx> > > > > Reported-by: Daniel Vetter <daniel@xxxxxxxx> > > > > > > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > > > > Please push to drm-misc-next. > > > > About that, I may need some help pushing it. > > I've already pushed a few minutes ago, so we don't disturb the build > tests any longer. Thanks a lot, laurentiu > > Regards, > Lucas > > > Apparently, my request for > > a legacy SSH account for contributing to drm-misc got stalled: > > > > https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/289 > > > > Thanks, > > laurentiu > > > > > -Daniel > > > > > > > > > > > > --- > > > > drivers/gpu/drm/imx/dcss/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig > > > > index 69860de8861f..2b17a964ff05 100644 > > > > --- a/drivers/gpu/drm/imx/dcss/Kconfig > > > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > > > > @@ -3,7 +3,7 @@ config DRM_IMX_DCSS > > > > select IMX_IRQSTEER > > > > select DRM_KMS_CMA_HELPER > > > > select VIDEOMODE_HELPERS > > > > - depends on DRM && ARCH_MXC > > > > + depends on DRM && ARCH_MXC && ARM64 > > > > help > > > > Choose this if you have a NXP i.MX8MQ based system and want to use the > > > > Display Controller Subsystem. This option enables DCSS support. > > > > -- > > > > 2.17.1 > > > > > > > > > > -- > > > Daniel Vetter > > > Software Engineer, Intel Corporation > > > http://blog.ffwll.ch > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
