Hi Morimoto-san, On Tue, Sep 8, 2020 at 2:34 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch adds FCP device nodes for R-Car M3-W+ (r8a77961) SoC. > This patch was tested on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2004,6 +2004,58 @@ pciec1: pcie@ee800000 { > status = "disabled"; > }; > > + fcpf0: fcp@fe950000 { > + compatible = "renesas,fcpf"; > + reg = <0 0xfe950000 0 0x200>; > + clocks = <&cpg CPG_MOD 615>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 615>; Missing "iommus = <&ipmmu_vc0 16>;" > + }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77961_PD_A3VC>; > + resets = <&cpg 607>; Missing "iommus = <&ipmmu_vi0 5>;" > + }; The rest looks good to me, so with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel