On 9/7/20 9:02 AM, Vaibhav Gupta wrote: > Linux Kernel Mentee: Remove Legacy Power Management. > > The original goal of the patch series is to upgrade the power management > framework of radeonfb fbdev driver. This has been done by upgrading .suspend() > and .resume() callbacks. > > The upgrade makes sure that the involvement of PCI Core does not change the > order of operations executed in a driver. Thus, does not change its behavior. > > During this process, it was found that "#if defined(CONFIG_PM)" at line 1434 is > redundant. This was introduced in the commit > 42ddb453a0cd ("radeon: Conditionally compile PM code"). > > ------------ > > Before 42ddb453a0cd: > $ git show 65122f7e80b5:drivers/video/aty/radeon_pm.c | grep -n "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef" > > Based on output in terminal: > > 547:#ifdef CONFIG_PM > |-- 959:#ifdef CONFIG_PPC_PMAC > |-- 972:#endif > |-- 1291:#ifdef CONFIG_PPC_OF > |-- 1301:#endif /* CONFIG_PPC_OF */ > |-- 1943:#ifdef CONFIG_PPC_OF > |-- 2206:#if 0 /* Not ready yet */ > |-- 2508:#endif /* 0 */ > |-- 2510:#endif /* CONFIG_PPC_OF */ > |-- 2648:#ifdef CONFIG_PPC_PMAC > |-- 2654:#endif /* CONFIG_PPC_PMAC */ > |-- 2768:#ifdef CONFIG_PPC_PMAC > |-- 2774:#endif /* CONFIG_PPC_PMAC */ > |-- 2791:#ifdef CONFIG_PPC_OF__disabled > |-- 2801:#endif /* CONFIG_PPC_OF */ > 2803:#endif /* CONFIG_PM */ > > ------------ > > After 42ddb453a0cd: > $ git show 42ddb453a0cd:drivers/video/aty/radeon_pm.c | grep -n "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef" > > Based on output in terminal: > > 547:#ifdef CONFIG_PM > |-- 959:#ifdef CONFIG_PPC_PMAC > |-- 972:#endif > |-- 1291:#ifdef CONFIG_PPC_OF > |-- 1301:#endif /* CONFIG_PPC_OF */ > |-- 1430:#if defined(CONFIG_PM) > |-- 1431:#if defined(CONFIG_X86) || defined(CONFIG_PPC_PMAC) > |-- 1944:#endif > |-- 1946:#ifdef CONFIG_PPC_OF > |-- 1947:#ifdef CONFIG_PPC_PMAC > |-- 2208:#endif > |-- 2209:#endif > |-- 2211:#if 0 /* Not ready yet */ > |-- 2513:#endif /* 0 */ > |-- 2515:#endif /* CONFIG_PPC_OF */ > |-- 2653:#ifdef CONFIG_PPC_PMAC > |-- 2659:#endif /* CONFIG_PPC_PMAC */ > |-- 2773:#ifdef CONFIG_PPC_PMAC > |-- 2779:#endif /* CONFIG_PPC_PMAC */ > |-- 2796:#ifdef CONFIG_PPC_OF__disabled > |-- 2806:#endif /* CONFIG_PPC_OF */ > 2808:#endif /* CONFIG_PM */ > > ------------ > > This also affected the CONFIG_PPC_OF container (line 1943 at commit 65122f7e80b5) > > The patch-series fixes it along with PM upgrade. > > All patches are compile-tested only. > > Test tools: > - Compiler: gcc (GCC) 10.1.0 > - allmodconfig build: make -j$(nproc) W=1 all > > Vaibhav Gupta (2): > video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container > fbdev: radeonfb:use generic power management > > drivers/video/fbdev/aty/radeon_base.c | 10 ++++--- > drivers/video/fbdev/aty/radeon_pm.c | 38 ++++++++++++++++++++------- > drivers/video/fbdev/aty/radeonfb.h | 3 +-- > 3 files changed, 35 insertions(+), 16 deletions(-) Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel