On Sun, Aug 23, 2020 at 12:45:13PM +0200, Sam Ravnborg wrote:
> Use dev_err_probe() to make some of the error handling
> simpler in the probe function.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> ---
> drivers/video/backlight/gpio_backlight.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index dc9354dc5e6a..1d509b626b12 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -65,13 +65,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> def_value = device_property_read_bool(dev, "default-on");
>
> gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
> - if (IS_ERR(gbl->gpiod)) {
> - ret = PTR_ERR(gbl->gpiod);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev,
> - "Error: The gpios parameter is missing or invalid.\n");
> - return ret;
> - }
> + if (IS_ERR(gbl->gpiod))
> + return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
> + "The gpios parameter is missing or invalid.\n");
>
> memset(&props, 0, sizeof(props));
> props.type = BACKLIGHT_RAW;
> --
> 2.25.1
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
