On Wed, Aug 19, 2020 at 5:08 AM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > > On 2020-07-22 7:12 p.m., Alex Deucher wrote: > > On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > >> On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > >>> On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >>>> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer <michel@xxxxxxxxxxx> wrote: > >>>>> > >>>>> From: Michel Dänzer <mdaenzer@xxxxxxxxxx> > >>>>> > >>>>> drm_atomic_crtc_check enforces that ::active can only be true if > >>>>> ::enable is as well. > >>>>> > >>>>> Signed-off-by: Michel Dänzer <mdaenzer@xxxxxxxxxx> > >>> > >>> Looks fine to me. The check is sufficiently old enough that I don't mind > >>> relying on the core for this either. > >>> > >>> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@xxxxxxx> > >>> > >>>> > >>>> modeset vs modereset is a bit an inglorious name choice ... since this > >>>> seems to be glue code and not part of core dc, maybe rename to > >>>> enable_required/disable_required to keep it consistent with the > >>>> wording atomic helpers use? DC also seems to use reset for a lot of > >>>> other things already (state reset, like atomic, or gpu reset like > >>>> drm/scheduler's td_r_), so I think this would also help clarity from a > >>>> DC perspective. > >>>> > >>>> Patch itself is good, above just an idea for another patch on top. > >>>> > >>>> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > >> > >> Thanks for the reviews! I assume this will get picked up by a DC > >> developer or Alex/Christian. > > > > Applied. Thanks! > > Thank you. Can't see it in the DRM changes for 5.9 though. Will show up for 5.10 as it didn't seem critical for 5.9. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
