Hi Sam, On Sun, Aug 16, 2020 at 09:04:17PM +0200, Sam Ravnborg wrote: > On Sun, Aug 16, 2020 at 07:55:21PM +0200, Guido Günther wrote: > > Hi Sam, > > thanks for having a look! > > > > On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > > > > On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote: > > > > The panel uses a Focaltech FT8006p, the touch part is handled by the > > > > already existing edt-ft5x06. > > > > > > > > Signed-off-by: Guido Günther <agx@xxxxxxxxxxx> > > > > > > Two small nits - otherwise looks good. > > > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > > > > I can fix while applying or you can send a new revision, > > > but I cannot apply until drm-misc-next have seen a backmerge > > > due to dev_err_probe() usage. > > > > I'll send out a v3 with this fixed. > > > > > Did you have commit rights yet? > > > If yes, then please apply yourself. > > > > No commit rights here. So it would be great if you could apply the > > patches. Should I look for commit rights? I assume that means following > > > > https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc > I recall we discussed this before for some other driver. > For a single panel it is not needed, but if you continue to be active > on other parts it makes sense. I think st7703, mantix and nwl all go in via drm-misc so it might make sense. Thanks for the suggestion! > I will apply v3 when drm-misc-next is backmeged unless you tell me > otherwise. And ping me if I forgets. Thanks! -- Guido _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
