Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sam,

On Thu, Aug 13, 2020 at 09:18:44PM +0200, Sam Ravnborg wrote:
> On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote:
> > The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel, set the bus
> > format to MEDIA_BUS_FMT_RGB666_1X18.
> > 
> > Fixes: 725c9d40f3fe ("drm/panel: Add support for OrtusTech COM43H4M85ULC panel")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/panel/panel-simple.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index ef8df838fe14..ef04fd75babd 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -3018,7 +3018,7 @@ static const struct panel_desc ortustech_com43h4m85ulc = {
> >  		.width = 56,
> >  		.height = 93,
> >  	},
> > -	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> > +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> >  	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> >  	.connector_type = DRM_MODE_CONNECTOR_DPI,
> >  };
> 
> So basically we say that this panel is bpc=8 but connected so we only
> utilise 6 bits per color - seems like a waste but may be good enough.
> There are other panels that is connected in the same way.

No, this is a 6 bpc panel, I just forgot to fix that :-S

> Applied.

Should I send a fix on top of drm-misc, or would you like to do so ?

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux