Hi Am 03.08.20 um 02:38 schrieb Tian Tao: > patch #1 and #3 is clean up, patch #2 is for code refactoring Sorry for all my reviews taking so long. Please merge patch #3 into patch #2 and then the series is Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> I noticed that hibmc use DRM_ERROR in several places. A good follow-up patchset would be the conversion to drm_info/drm_warn/drm_error/etc. Best regards Thomas > > Changes since v1: > - Rewrite the commits messages and patch name in #1 > - Rewrite the commits message in #2. > - Add the new patch #3 > > Tian Tao (3): > drm/hisilicon: Remove the unused include statements > drm/hisilicon: Code refactoring for hibmc_drv_de > drm/hisilicon: Rename variables to represent the correct meaning > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 58 ++++++------------------ > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 -- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 + > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 - > 4 files changed, 15 insertions(+), 52 deletions(-) > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
