On Wed, 12 Aug 2020 at 05:34, Dave Airlie <airlied@xxxxxxxxx> wrote: > > On Wed, 12 Aug 2020 at 03:11, Christian König > <ckoenig.leichtzumerken@xxxxxxxxx> wrote: > > > > Am 11.08.20 um 18:42 schrieb Michel Dänzer: > > > On 2020-08-11 2:53 p.m., Christian König wrote: > > >> Am 11.08.20 um 14:52 schrieb Christian König: > > >>> Am 11.08.20 um 11:24 schrieb Christian König: > > >>>> This reverts commit 2ddef17678bc2ea1d20517dd2b4ed4aa967ffa8b. > > >>>> > > >>>> As it turned out VMWGFX needs a much wider audit to fix this. > > >>>> > > >>>> Signed-off-by: Christian König <christian.koenig@xxxxxxx> > > >>> Dare to give me an rb for this? I already tested on amdgpu and it > > >>> should be fixing the VMWGFX problems we currently have. > > >> Ups, that was your old AMD address :) > > >> > > >> So once more with feeling, > > > :) > > > > > > However, I'm afraid I'm not deep enough into TTM code anymore to give > > > you an R-b, given it's not a straight revert (presumably due to other > > > changes in the meantime). > > > > Yeah, indeed had to keep Daves changes intact. > > > > Dave can you take a look then? > > Yup just came in after my "stop working Dave" time. > > Did you have an amdgpu patch that worked on top of this? does that > need reverting or did it not land yet? Oh I confused this with the ttm_mem_reg handling fix that had an amdgpu patch. I'll pull this into my fixes tree for Linus now. Dave. > > Otherwise, > > Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel