Am 11.08.20 um 10:49 schrieb Dave Airlie:
On Tue, 11 Aug 2020 at 18:42, Christian König
<ckoenig.leichtzumerken@xxxxxxxxx> wrote:
I've totally missed those and still don't see any reference in any inbox
to the original mail or patch #2 in this series.
I forgot to cc you on the original posting, but they should be on dri-devel
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F80517%2F&data=02%7C01%7Cchristian.koenig%40amd.com%7C9ba8068c644a495b35a308d83dd37b82%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637327326072901891&sdata=YoLRGkStydOIQEZUL7rq1Om58uSNu6wj7bYy7yEshbw%3D&reserved=0
Reviewed-by: Christian König <christian.koenig@xxxxxxx> for both.
But this patch at least looks like it makes a lot of sense.
BTW: Does anybody know why we separate base and offset here? That
distinction seems to be superfluous as well.
I think base is only used for premapped objects,
Yeah, but take a look how it is used. As far as I know we don't have a
single case where we don't do "mem->bus.base + mem->bus.offset".
If that's true (needs double checking) then why the heck do we have two
fields for this?
Regards,
Christian.
Dave.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
