On Mon, Aug 10, 2020 at 09:00:11PM +0800, Qinglang Miao wrote: > When vkms_init() get into out_put, the unregister call of > vkms_device->platform is missing. So add it before return. > > Fixes: c27f0cc4d43a "drm/vkms: enable cursor by default" This is the wrong commit, I fixed that up while applying. -Daniel > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx> > --- > drivers/gpu/drm/vkms/vkms_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c > index 57a8a397d..83dd5567d 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.c > +++ b/drivers/gpu/drm/vkms/vkms_drv.c > @@ -190,8 +190,8 @@ static int __init vkms_init(void) > > out_put: > drm_dev_put(&vkms_device->drm); > + platform_device_unregister(vkms_device->platform); > return ret; > - > out_unregister: > platform_device_unregister(vkms_device->platform); > out_free: > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel