On Mon, Aug 10, 2020 at 08:59:42PM +0800, Qinglang Miao wrote: > When vgem_init() get into out_put, the unregister call of > vgem_device->platform is missing. So add it before return. > > Fixes: 363de9e7d4f6 "drm/vgem: Use drmm_add_final_kfree" > Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx> Uh right I still have my series stuck which would have fixed this properly ... Thanks for your fix, both applied to drm-misc-next. -Daniel > --- > drivers/gpu/drm/vgem/vgem_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c > index a775feda1..313339bbf 100644 > --- a/drivers/gpu/drm/vgem/vgem_drv.c > +++ b/drivers/gpu/drm/vgem/vgem_drv.c > @@ -471,8 +471,8 @@ static int __init vgem_init(void) > > out_put: > drm_dev_put(&vgem_device->drm); > + platform_device_unregister(vgem_device->platform); > return ret; > - > out_unregister: > platform_device_unregister(vgem_device->platform); > out_free: > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
