Hi Prabhakar, Thank you for the patch. On Fri, Aug 07, 2020 at 06:49:49PM +0100, Lad Prabhakar wrote: > Add direct support for the r8a7742 (RZ/G1H). > > The RZ/G1H shares a common, compatible configuration with the r8a7790 > (R-Car H2) so that device info structure is reused, the only difference > being TCON is unsupported on RZ/G1H (Currently unsupported by the driver). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 3e67cf70f040..7e286c7a7a6c 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -216,8 +216,8 @@ static const struct rcar_du_device_info rcar_du_r8a7790_info = { > .channels_mask = BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > - * R8A7790 has one RGB output, two LVDS outputs and one > - * (currently unsupported) TCON output. > + * R8A7742 and R8A7790 each have one RGB output and two LVDS outputs. Additionally > + * R8A7790 supports one TCON output (currently unsupported by the driver). Once we support TCON we'll have to split this, but for now I suppose it's fine. Would you however mind wrapping this to 80 columns ? I can do so when applying if it's fine with you. Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > */ > [RCAR_DU_OUTPUT_DPAD0] = { > .possible_crtcs = BIT(2) | BIT(1) | BIT(0), > @@ -443,6 +443,7 @@ static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > }; > > static const struct of_device_id rcar_du_of_table[] = { > + { .compatible = "renesas,du-r8a7742", .data = &rcar_du_r8a7790_info }, > { .compatible = "renesas,du-r8a7743", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel