Re: [PATCH] drm/mgag200: Set PCI option register in G200SE models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 4 Aug 2020 at 16:52, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
>
> The initial value of the PCI option register got lost while refactoring
> the driver init code. Restore the setting.
>

Ooops,

Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>

> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
> Cc: Lyude Paul <lyude@xxxxxxxxxx>
> Cc: Dave Airlie <airlied@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> Cc: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 5c854bc7dc86..09170d46aa53 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
>                 break;
>         case G200_SE_A:
>         case G200_SE_B:
> +               option = 0x40049120;
>                 if (mgag200_has_sgram(mdev))
>                         option |= PCI_MGA_OPTION_HARDPWMSK;
>                 option2 = 0x00008000;
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux