On Fri, Jul 31, 2020 at 05:21:38PM +1000, Dave Airlie wrote: > On Fri, 31 Jul 2020 at 17:14, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote: > > > > Hi > > > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > > From: Dave Airlie <airlied@xxxxxxxxxx> > > > > > > This will allow different abstractions later. > > > > You should consider moving this patch to the beginning of the series, so > > that patches 1 to 25 can benefit from it. > > I did consider it, but I'd have to move all the follow on patches as > well, and it got messy in rebase land, and I started introducing > errors, so I left it alone, and it's not necessary until the patch > that changes it's definition anyways. I like this ordering a lot better, it gives a clear separation between the different steps. Some code gets touched multiple times, but interleaving the demidlayering would only make this worse I think. -Daniel > > Dave. > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel