On Fri, Jul 31, 2020 at 04:26:08PM +1000, Dave Airlie wrote:
> On Fri, 31 Jul 2020 at 15:51, Dave Airlie <airlied@xxxxxxxxx> wrote:
> >
> > On Fri, 31 Jul 2020 at 15:44, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> > >
> > > Hi Dave.
> > >
> > > On Fri, Jul 31, 2020 at 02:04:34PM +1000, Dave Airlie wrote:
> > > > From: Dave Airlie <airlied@xxxxxxxxxx>
> > > >
> > > > This will allow the driver to control the ordering here better.
> > > >
> > > > Eventually the old path will be removed.
> > > >
> > > > Signed-off-by: Dave Airlie <airlied@xxxxxxxxxx>
> > > > ---
> > > > drivers/gpu/drm/ttm/ttm_bo.c | 34 +++++++++++++++++++--------------
> > > > include/drm/ttm/ttm_bo_api.h | 4 ++++
> > > > include/drm/ttm/ttm_bo_driver.h | 6 ++++++
> > > > 3 files changed, 30 insertions(+), 14 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> > > > index 041a0e73cd1b..a658fd584c6d 100644
> > > > --- a/drivers/gpu/drm/ttm/ttm_bo.c
> > > > +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> > > > @@ -1503,35 +1503,41 @@ int ttm_bo_evict_mm(struct ttm_bo_device *bdev, unsigned mem_type)
> > > > }
> > > > EXPORT_SYMBOL(ttm_bo_evict_mm);
> > > >
> > > > -int ttm_bo_init_mm(struct ttm_bo_device *bdev, unsigned type,
> > > > - unsigned long p_size)
> > > > +void ttm_bo_init_mm_base(struct ttm_bo_device *bdev,
> > > > + struct ttm_mem_type_manager *man,
> > > > + unsigned long p_size)
> > > > {
> > >
> > > General comment for all the ttm/* changes.
> > > It would be very nice with some nice explanations for the exported
> > > functions, preferably in kernel-doc style.
> > > In case someone that are more or less clueless (like me) would like
> > > to understand how a function is to be used or maybe reviewing some
> > > random code.
> >
> > Good point, I just need to make sure I don't add anything for
> > something I remove later, but I should definitely add some for the new
> > interfaces.
>
> The version in my git branch has docs for all the new apis now.
Thanks!
And now I am more or less oblieged to read/review the docs when you
submit v2 - yeah, more reviews.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
