Hi Laurent. On Wed, Jul 29, 2020 at 07:29:08PM +0300, Laurent Pinchart wrote: > Enabling a whole subsystem from a single driver 'select' is frowned > upon and won't be accepted in new drivers, that need to use 'depends on' > instead. Existing selection of DMAENGINES will then cause circular > dependencies. Replace them with a dependency. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > --- > drivers/rapidio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig > index e4c422d806be..b9f8514909bf 100644 > --- a/drivers/rapidio/Kconfig > +++ b/drivers/rapidio/Kconfig > @@ -37,7 +37,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS > config RAPIDIO_DMA_ENGINE > bool "DMA Engine support for RapidIO" > depends on RAPIDIO > - select DMADEVICES > + depends on DMADEVICES $subject and changlog talks about DMAENGINES but the patch touches DMADEVICES?? Sam > select DMA_ENGINE > help > Say Y here if you want to use DMA Engine frameork for RapidIO data > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
