On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > Hi Paul. > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > Here are a few cleanups to the ingenic-drm driver. > > - some error paths were missing and have been added; > > - the mode validation has been moved to the .mode_valid helper callback. > > > > Cheers, > > -Paul > > > > Paul Cercueil (2): > > drm/ingenic: Handle errors of drm_atomic_get_plane_state > > drm/ingenic: Validate mode in a .mode_valid callback > > Both looks fine, you can add my: > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > I assume you will apply the patches. > Maybe wait for Daniel to take a look, he had some feedback on where > to add checks. I assume this is covered by the second patch. Yeah changelog for new versions would be great, but aside from that bickering patch 2 lgtm now. Cheers, Daniel > > Sam > > > > > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 41 +++++++++++++++-------- > > 1 file changed, 27 insertions(+), 14 deletions(-) > > > > -- > > 2.27.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
