On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen <melissa.srw@xxxxxxxxx> wrote: > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen <melissa.srw@xxxxxxxxx> wrote: > > > > > No, this very first warning continues (only once) :( > > > From here (drm_crtc_vblank_on): > > > if (atomic_read(&vblank->refcount) != 0 || drm_vblank_offdelay == 0) > > > drm_WARN_ON(dev, drm_vblank_enable(dev, pipe)); > > > > Sorry, not sure when this warning is triggered. > > Again, I just had to look at the trace: > [ 52.299388] drm_get_last_vbltimestamp+0xaa/0xc0 [drm] > [ 52.299389] drm_reset_vblank_timestamp+0x5b/0xd0 [drm] > [ 52.299389] drm_crtc_vblank_on.cold+0x37/0x103 [drm] > [ 52.299390] drm_atomic_helper_commit_modeset_enable Yeah I think vkms can't generate a reasonable timestamp when the hrtimer is off. I thought the warning comes from a different callchain, but seems to be a general problem. I guess in the vkms timestamp function we should check whether the timer is running, and if it's not running, then we just grab the current time and done. -Daniel > > > > > > > > > But I'm still wondering why after step 3 we don't get -EINVAL from > > > > vblank_get() - after vblank_off() vblank->enabled should be false > > > > again, getting us back to the same state as after 1. Is that not > > > > happening? > > > > > > Yes (sorry if it got confused), we got -EINVAL after setp 3: > > > > > > In step 3, at the end of the 2nd running, we have: > > > atomic_disable > > > --> vblank_off [!vblank->inmodeset + refcount going 0->1 + inmodeset=1] > > > and then in next vblank_get: -EINVAL (!vblank->enabled + refcount ends 1) > > > as in the first step. > > > > > > Melissa > > > > > > > -Daniel > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > -Sidong > > > > > > > > > > > > > > > > > > > > > > > > > > > > crtc->state->event = NULL; > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > 2.27.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Daniel Vetter > > > > > > > > > > Software Engineer, Intel Corporation > > > > > > > > > > http://blog.ffwll.ch > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Daniel Vetter > > > > > > > > Software Engineer, Intel Corporation > > > > > > > > http://blog.ffwll.ch > > > > > > > > _______________________________________________ > > > > > > > > dri-devel mailing list > > > > > > > > dri-devel@xxxxxxxxxxxxxxxxxxxxx > > > > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Daniel Vetter > > > > > > Software Engineer, Intel Corporation > > > > > > http://blog.ffwll.ch > > > > > > > > > > > > > > > > -- > > > > Daniel Vetter > > > > Software Engineer, Intel Corporation > > > > http://blog.ffwll.ch -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
