Re: [PATCH 11/11] drm/ttm: remove TTM_MEMTYPE_FLAG_MAPPABLE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20200720]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.8-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-remove-optional-dummy-function-from-drivers-using-TTM/20200721-153530
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/drm_gem_vram_helper.c: In function 'bo_driver_init_mem_type':
>> drivers/gpu/drm/drm_gem_vram_helper.c:1012:16: error: 'TTM_MEMTYPE_FLAG_MAPPABLE' undeclared (first use in this function); did you mean 'TTM_MEMTYPE_FLAG_FIXED'?
    1012 |   man->flags = TTM_MEMTYPE_FLAG_MAPPABLE;
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                TTM_MEMTYPE_FLAG_FIXED
   drivers/gpu/drm/drm_gem_vram_helper.c:1012:16: note: each undeclared identifier is reported only once for each function it appears in
   drivers/gpu/drm/drm_gem_vram_helper.c: In function 'bo_driver_io_mem_reserve':
   drivers/gpu/drm/drm_gem_vram_helper.c:1065:21: error: 'TTM_MEMTYPE_FLAG_MAPPABLE' undeclared (first use in this function); did you mean 'TTM_MEMTYPE_FLAG_FIXED'?
    1065 |  if (!(man->flags & TTM_MEMTYPE_FLAG_MAPPABLE))
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                     TTM_MEMTYPE_FLAG_FIXED

vim +1012 drivers/gpu/drm/drm_gem_vram_helper.c

6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1006  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1007  static int bo_driver_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1008  				   struct ttm_mem_type_manager *man)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1009  {
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1010  	switch (type) {
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1011  	case TTM_PL_SYSTEM:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11 @1012  		man->flags = TTM_MEMTYPE_FLAG_MAPPABLE;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1013  		man->available_caching = TTM_PL_MASK_CACHING;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1014  		man->default_caching = TTM_PL_FLAG_CACHED;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1015  		break;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1016  	case TTM_PL_VRAM:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1017  		man->func = &ttm_bo_manager_func;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1018  		man->flags = TTM_MEMTYPE_FLAG_FIXED |
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1019  			     TTM_MEMTYPE_FLAG_MAPPABLE;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1020  		man->available_caching = TTM_PL_FLAG_UNCACHED |
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1021  					 TTM_PL_FLAG_WC;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1022  		man->default_caching = TTM_PL_FLAG_WC;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1023  		break;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1024  	default:
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1025  		return -EINVAL;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1026  	}
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1027  	return 0;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1028  }
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  1029  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux