Hi Sam, Thank you for the patch. On Fri, Jul 03, 2020 at 09:24:06PM +0200, Sam Ravnborg wrote: > The ti-tpd12s015 do not create any connector, so ignore > the flags argument, just pass it on to the next bridge > in the chain. > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx> > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Jonas Karlman <jonas@xxxxxxxxx> > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > --- > drivers/gpu/drm/bridge/ti-tpd12s015.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tpd12s015.c b/drivers/gpu/drm/bridge/ti-tpd12s015.c > index 514cbf0eac75..4f1666422ab2 100644 > --- a/drivers/gpu/drm/bridge/ti-tpd12s015.c > +++ b/drivers/gpu/drm/bridge/ti-tpd12s015.c > @@ -43,9 +43,6 @@ static int tpd12s015_attach(struct drm_bridge *bridge, > struct tpd12s015_device *tpd = to_tpd12s015(bridge); > int ret; > > - if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) > - return -EINVAL; > - The driver is only used by devices that use DRM_BRIDGE_ATTACH_NO_CONNECTOR. I'd rather keep this check and port other potential users to DRM_BRIDGE_ATTACH_NO_CONNECTOR instead of allowing operation in !DRM_BRIDGE_ATTACH_NO_CONNECTOR mode. > ret = drm_bridge_attach(bridge->encoder, tpd->next_bridge, > bridge, flags); > if (ret < 0) -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
