Hi Suraj. On Tue, Jul 07, 2020 at 10:04:14PM +0530, Suraj Upadhyay wrote: > > This patchset converts logging to drm_* functions in drm core. > > The following functions have been converted to their respective > DRM alternatives : > dev_info() --> drm_info() > dev_err() --> drm_err() > dev_warn() --> drm_warn() > dev_err_once() --> drm_err_once(). I would prefer that DRM_* logging in the same files are converted in the same patch. So we have one logging conversion patch for each file you touches and that we do not need to re-vist the files later to change another set of logging functions. If possible WARN_* should also be converted to drm_WARN_* If patch is too large, then split them up but again lets have all logging updated when we touch a file. Care to take a look at this approach? Also please consider if coccinelle can make this job easier. There is a lot of files... Sam > > Suraj Upadhyay (4): > drm: mipi-dsi: Convert logging to drm_* functions. > drm: mipi-dbi: Convert logging to drm_* functions. > drm: edid: Convert logging to drm_* functions. > drm: fb-helper: Convert logging to drm_* functions. > > drivers/gpu/drm/drm_edid.c | 7 +++---- > drivers/gpu/drm/drm_fb_helper.c | 2 +- > drivers/gpu/drm/drm_mipi_dbi.c | 4 ++-- > drivers/gpu/drm/drm_mipi_dsi.c | 15 +++++++-------- > 4 files changed, 13 insertions(+), 15 deletions(-) > > -- > 2.17.1 > > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
