On Wed, Jul 8, 2020 at 12:43 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Here is the privacy-screen related code which we discussed a while ago. > This series consists of a number of different parts: > > 1. A new version of Rajat's privacy-screen connector properties patch, > this adds new userspace API in the form of new properties > > 2. Since on most devices the privacy screen is actually controlled by > some vendor specific ACPI/WMI interface which has a driver under > drivers/platform/x86, we need some "glue" code to make this functionality > available to KMS drivers. Patches 3-5 add a new privacy-screen class for > this, which allows non KMS drivers (and possibly KMS drivers too) to > register a privacy-screen device and also adds an interface for KMS drivers > to get access to the privacy-screen associated with a specific connector. > This is modelled similar to how we deal with e.g. PWMs and GPIOs in the > kernel, including separate includes for consumers and providers(drivers). > > 3. Some drm_connector helper functions to keep the actual changes needed > for this in individual KMS drivers as small as possible (patch 6). > > 4. Make the thinkpad_acpi code register a privacy-screen device on > ThinkPads with a privacy-screen (patches 7-8) > > 5. Make the i915 driver export the privacy-screen functionality through > the connector properties on the eDP connector. Care to create a patch 10 for amdgpu? Lenovo sells AMD thinkpads with a privacy screen as well, presumably it works the same way. Alex > > I was a bit in doubt if I should calls this series a RFC, or just call > it v1, since there is no real userspace code using this yet. It was > tested using xrandr property access and udevadm event monitoring. > I do expect / hope we will have patches for a userspace consumer of the > new properties (mutter) ready soon. > > But since the code is completely ready, including API documentation, > I've decided to just call this v1. Hopefully we can get patches for the > first userspace consumer of this ready during the review of this. > > Regards, > > Hans > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
